Messages in this thread Patch in this message | | | From | Peter Senna Tschudin <> | Subject | [PATCH 06/19] media: Change variable type to bool | Date | Sun, 22 Sep 2013 00:27:38 +0200 |
| |
The variable frame_ready is only assigned the values true and false. Change its type to bool.
The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/):
@exists@ type T; identifier b; @@ - T + bool b = ...; ... when any b = \(true\|false\)
Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> ---
This fails at checkpatch due initializing static variable to false. I haven't changed the assignment.
drivers/media/usb/cpia2/cpia2_usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/cpia2/cpia2_usb.c b/drivers/media/usb/cpia2/cpia2_usb.c index be17192..351a78a 100644 --- a/drivers/media/usb/cpia2/cpia2_usb.c +++ b/drivers/media/usb/cpia2/cpia2_usb.c @@ -209,7 +209,7 @@ static void cpia2_usb_complete(struct urb *urb) { int i; unsigned char *cdata; - static int frame_ready = false; + static bool frame_ready = false; struct camera_data *cam = (struct camera_data *) urb->context; if (urb->status!=0) { -- 1.8.3.1
| |