Messages in this thread |  | | Date | Fri, 20 Sep 2013 10:16:48 -0700 | Subject | Re: [RFC PATCH] ARM: OMAP3630: Add generic machine descriptor | From | Olof Johansson <> |
| |
On Fri, Sep 20, 2013 at 9:23 AM, Felipe Balbi <balbi@ti.com> wrote: > Hi, > > On Fri, Sep 20, 2013 at 09:19:02AM -0700, Olof Johansson wrote: >> On Fri, Sep 20, 2013 at 9:08 AM, Nishanth Menon <nm@ti.com> wrote: >> > An alternative approach may be to (for all SoCs): >> > 1. define every SoC entry - ti,omap3430 ti,omap3630... >> > 2. have a generic omap3_init which uses "if (of_machine_is_compatible("ti,omap3630"))" >> > to invoke the appropriate omap3xxx_init_early. >> >> Yes, this would be better, but you can do add a DT_MACHINE as in this >> patch but have ti,omap3630 as the dt_compat table. Then there's no >> need to add runtime checks. > > I was going to reply that adding of_machine_is_compatible("ti,omap3630") > would help in some situations, but guess it's already tainted ;-)
Oh, if it's just a few checks, then by all means go down that route. I didn't look at the code to see how much it would be.
But if a new DT_MACHINE is added, then it should definitely be based on ti,omap3630 instead of listing all the boards.
-Olof
|  |