Messages in this thread |  | | Date | Fri, 20 Sep 2013 10:01:35 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input: atmel_tscadcc - update to devm_* API |
| |
Hi Manish,
On Mon, Sep 16, 2013 at 08:22:58PM +0530, Manish Badarkhe wrote: > static int atmel_tsadcc_remove(struct platform_device *pdev) > { > struct atmel_tsadcc *ts_dev = platform_get_drvdata(pdev); > - struct resource *res; > - > - free_irq(ts_dev->irq, ts_dev); > > input_unregister_device(ts_dev->input); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - iounmap(tsc_base); > - release_mem_region(res->start, resource_size(res)); > - > clk_disable(ts_dev->clk); > - clk_put(ts_dev->clk); > - > - kfree(ts_dev); > > return 0; > }
By doing this conversion we disable the clock too early. I need to resurrect my patches to add devm_clk_enable and then we can revisit this patch.
Thanks.
-- Dmitry
|  |