Messages in this thread |  | | Date | Fri, 20 Sep 2013 18:41:44 +0200 | From | Oleg Nesterov <> | Subject | Re: do_wait: Add missing tasklist unlocking in error paths. |
| |
On 09/20, Dave Jones wrote: > > It looks like both 64a16caf5, and 98abed020 both introduced error paths to do_wait > where we miss unlocking the tasklist. > > Spotted with coverity.
Not really, afaics.
> --- a/kernel/exit.c > +++ b/kernel/exit.c > @@ -1526,13 +1526,15 @@ repeat: > tsk = current; > do { > retval = do_wait_thread(wo, tsk); > - if (retval) > + if (retval) { > + read_unlock(&tasklist_lock);
note that do_wait_thread() paths should drop tasklist if it returns non-zero.
Oleg.
|  |