Messages in this thread | | | Date | Fri, 20 Sep 2013 11:23:30 -0500 | From | Felipe Balbi <> | Subject | Re: [RFC PATCH] ARM: OMAP3630: Add generic machine descriptor |
| |
Hi,
On Fri, Sep 20, 2013 at 09:19:02AM -0700, Olof Johansson wrote: > On Fri, Sep 20, 2013 at 9:08 AM, Nishanth Menon <nm@ti.com> wrote: > > An alternative approach may be to (for all SoCs): > > 1. define every SoC entry - ti,omap3430 ti,omap3630... > > 2. have a generic omap3_init which uses "if (of_machine_is_compatible("ti,omap3630"))" > > to invoke the appropriate omap3xxx_init_early. > > Yes, this would be better, but you can do add a DT_MACHINE as in this > patch but have ti,omap3630 as the dt_compat table. Then there's no > need to add runtime checks.
I was going to reply that adding of_machine_is_compatible("ti,omap3630") would help in some situations, but guess it's already tainted ;-)
cheers
-- balbi [unhandled content-type:application/pgp-signature] | |