lkml.org 
[lkml]   [2013]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 15/24] Staging: winbond: reg: seventh of the patches that fixes lines over 80 characters
On Tue, 17 Sep 2013 12:43:26 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> On Tue, Sep 17, 2013 at 02:29:22PM +0530, Adil Mujeeb wrote:
> > Hi,
> >
> >
> > >- PowerData = (1 << 31) | (0 << 30) | (24 << 24) |
> > BitReverse(w89rf242_txvga_data[i][0], 24);
> > >+ PowerData = (1 << 31) | (0 << 30) | (24 << 24)
> > >+ | BitReverse(w89rf242_txvga_data[i][0], 24);
> > .....
> > .....
> >
> > >- reg->M38_MacControl = (DEFAULT_RATE_RETRY_LIMIT << 8) |
> > (DEFAULT_LONG_RETRY_LIMIT << 4) | DEFAULT_SHORT_RETRY_LIMIT;
> > >+ reg->M38_MacControl = (DEFAULT_RATE_RETRY_LIMIT << 8) |
> > >+ (DEFAULT_LONG_RETRY_LIMIT << 4) |
> > >+ DEFAULT_SHORT_RETRY_LIMIT;
> >
> > I think consistency is needed. Either break the lines putting the OR
> > operator ( | ) at the start of new line or at the end of each line. People
> > has its own preference but here you have used both style in single file.
> > Just a suggestion.
> >
>
> Put the '|' character at the end of the line. That's the New Unwritten
> Style Guidelines. Most of the kernel does it this way and it's easier
> to read.
>
> But this could be fixed in a later patch instead of redoing the whole
> series.
>
> regards,
> dan carpenter
>

I will change it for the new version of this patch but I want to wait some days until everybody looks the patches that I've sent.


--
Regards,

Iker Pedrosa <ikerpedrosam@gmail.com>


\
 
 \ /
  Last update: 2013-09-20 17:21    [W:0.045 / U:6.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site