lkml.org 
[lkml]   [2013]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 46/50] sched: numa: Prevent parallel updates to group stats during placement
On Fri, Sep 20, 2013 at 01:31:51PM +0100, Mel Gorman wrote:
> @@ -1402,14 +1394,15 @@ unlock:
> if (!join)
> return;
>
> + double_lock(&my_grp->lock, &grp->lock);
> +
> for (i = 0; i < 2*nr_node_ids; i++) {
> - atomic_long_sub(p->numa_faults[i], &my_grp->faults[i]);
> - atomic_long_add(p->numa_faults[i], &grp->faults[i]);
> + my_grp->faults[i] -= p->numa_faults[i];
> + grp->faults[i] -= p->numa_faults[i];
> + WARN_ON_ONCE(grp->faults[i] < 0);
> }

That stupidity got fixed

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2013-09-20 15:41    [W:0.181 / U:5.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site