lkml.org 
[lkml]   [2013]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] checkpatch: Add warning about submitting patches using --file
    On Mon, Sep 02, 2013 at 12:40:47PM -0700, Joe Perches wrote:
    > +WARNING: When using --file mode, do not send patches that just make
    > +whitespace or formatting changes unless more significant changes are
    > +also made for other reasons in another patch.
    > +

    This is a run on sentence. Also I don't agree with it. Clean up
    patches are good on their own. There are parts of the kernel which are
    not just in staging where I refuse to look at because it is so bad.

    The problem is that people send "clean up" patches which don't clean up
    the code or which make the code worse than the original. All they care
    about is pleasing checkpatch.pl instead of actually thinking about what
    they are doing. The message should just say something like, "Take a
    step back and think about if this actually improves things for human
    readers."

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2013-09-02 22:41    [W:4.947 / U:0.828 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site