lkml.org 
[lkml]   [2013]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] mm/hwpoison: fix false report 2nd try page recovery
On Mon, Sep 02, 2013 at 08:33:43PM +0800, Wanpeng Li wrote:
> If the page is poisoned by software inject w/ MF_COUNT_INCREASED flag, there
> is a false report 2nd try page recovery which is not truth, this patch fix it
> by report first try free buddy page recovery if MF_COUNT_INCREASED is set.
>
> Before patch:
>
> [ 346.332041] Injecting memory failure at pfn 200010
> [ 346.332189] MCE 0x200010: free buddy, 2nd try page recovery: Delayed
>
> After patch:
>
> [ 297.742600] Injecting memory failure at pfn 200010
> [ 297.742941] MCE 0x200010: free buddy page recovery: Delayed
>
> Signed-off-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

> ---
> mm/memory-failure.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-failure.c b/mm/memory-failure.c
> index b114570..6293164 100644
> --- a/mm/memory-failure.c
> +++ b/mm/memory-failure.c
> @@ -1114,8 +1114,10 @@ int memory_failure(unsigned long pfn, int trapno, int flags)
> * shake_page could have turned it free.
> */
> if (is_free_buddy_page(p)) {
> - action_result(pfn, "free buddy, 2nd try",
> - DELAYED);
> + if (flags & MF_COUNT_INCREASED)
> + action_result(pfn, "free buddy", DELAYED);
> + else
> + action_result(pfn, "free buddy, 2nd try", DELAYED);
> return 0;
> }
> action_result(pfn, "non LRU", IGNORED);
> --
> 1.7.5.4
>


\
 
 \ /
  Last update: 2013-09-02 20:41    [W:0.048 / U:1.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site