lkml.org 
[lkml]   [2013]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 47/58] nilfs2: remove double bio_put() in nilfs_end_bio_write() for BIO_EOPNOTSUPP error
    Date
    3.5.7.21 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vyacheslav Dubeyko <slava@dubeyko.com>

    commit 2df37a19c686c2d7c4e9b4ce1505b5141e3e5552 upstream.

    Remove double call of bio_put() in nilfs_end_bio_write() for the case of
    BIO_EOPNOTSUPP error detection. The issue was found by Dan Carpenter
    and he suggests first version of the fix too.

    Signed-off-by: Vyacheslav Dubeyko <slava@dubeyko.com>
    Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Tested-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    fs/nilfs2/segbuf.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/nilfs2/segbuf.c b/fs/nilfs2/segbuf.c
    index dc9a913..5bacf46 100644
    --- a/fs/nilfs2/segbuf.c
    +++ b/fs/nilfs2/segbuf.c
    @@ -345,8 +345,7 @@ static void nilfs_end_bio_write(struct bio *bio, int err)

    if (err == -EOPNOTSUPP) {
    set_bit(BIO_EOPNOTSUPP, &bio->bi_flags);
    - bio_put(bio);
    - /* to be detected by submit_seg_bio() */
    + /* to be detected by nilfs_segbuf_submit_bio() */
    }

    if (!uptodate)
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-09-02 13:41    [W:4.207 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site