Messages in this thread | | | Date | Mon, 2 Sep 2013 10:50:10 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH 1/2] mfd: 88pm800: Fix the bug that pdata may be NULL |
| |
Hi Chao,
On Mon, Sep 02, 2013 at 09:21:04AM +0800, Chao Xie wrote: > On Fri, Aug 30, 2013 at 8:30 PM, Samuel Ortiz <sameo@linux.intel.com> wrote: > > Hi Xie, > > > > On Tue, Aug 27, 2013 at 02:11:58PM +0800, Chao Xie wrote: > >> On Tue, Aug 20, 2013 at 9:40 AM, Samuel Ortiz <sameo@linux.intel.com> wrote: > >> > Hi Xie, > >> > > >> > On Sun, Aug 18, 2013 at 09:27:54PM -0400, Chao Xie wrote: > >> >> User pass platform data to device, and platform data may be > >> >> NULL. > >> > In which case do you get that ? With DT ? > >> > Should rtc_init fail when pdata is NULL ? > >> > > >> > You need to explain that, be it only for us to know if it's a critical > >> > fix or not. > >> > > >> Sorry for late response. > >> If pdata is NULL, the driver will fail. > > The question is: Why would pdata be NULL ? If there's a fundamental > > issue you're hiding with this patch, you probably want to fix the real > > problem instead. > > > Maybe i do not explain it clearly. > The error is detected y some software checking tool. Ok, that's clearer. So it's not an actual bug you saw in practice, I'll modify the changelog accordingly.
Cheers, Samuel.
-- Intel Open Source Technology Centre http://oss.intel.com/
| |