Messages in this thread | | | From | Robert Baldyga <> | Subject | [PATCH v3 0/7] usb: s3c-hsotg: fixes for proper functioning | Date | Thu, 19 Sep 2013 11:50:16 +0200 |
| |
Hello,
This is a third version of set of patches fixing s3c-hsotg USB driver functioning. From the previous vesrion there are two changes - fixed one small mistake found in one of patches, and add new patch fixing interrupt configuration for dedicated-fifo mode.
These patches add few fixes: - Fix "protocol stall" handling, by enqueue new ep0 request when stalled - Fix s3c_hsotg_write_fifo function to be usable in dedicated-fifo mode. Actually PTxFEmp/NPTxFEmp interrupts are enabled only in shared-fifo mode. - Fix endpoint interrput handling, by disabling interrupts for endpoints which has no requests enqueued. - Fixed DAINT register usage. Now only masked ep interrupts are handled. - Fix "halt" property updating. - Fix endpoint halt clearing, when it is not currently halted. - Fix interrupt configuration in dedicated fifo mode.
Best regards Robert Baldyga Samsung R&D Institute Poland
Changelog:
v3: - in patch 'fix clear feature ENDPOINT_HALT' fixed mistake in that logic OR were used instead of logic AND - add patch setting correct interrupt configuration for dedicated-fifo mode
v2: https://lkml.org/lkml/2013/9/18/99 - splitted patches to get one fix in each patch, as Felipe Balbi suggested - fixed typos
v1: https://lkml.org/lkml/2013/9/12/324 - initial proposal
Robert Baldyga (7): USB: gadget: s3c-hsotg: fix "protocol stall" handling USB: gadget: s3c-hsotg: fix s3c_hsotg_write_fifo function for dedicated fifo mode USB: gadget: s3c-hsotg: fix endpoint interrupts handling USB: gadget: s3c-hsotg: add DAINT masking USB: gadget: s3c-hsotg: fix "halted" property updating USB: gadget: s3c-hsotg: fix clear feature ENDPOINT_HALT USB: gadget: s3c-hsotg: fix interrupt configuration in dedicated-fifo mode
drivers/usb/gadget/s3c-hsotg.c | 74 +++++++++++++++++++++++++++++++--------- 1 file changed, 57 insertions(+), 17 deletions(-)
-- 1.7.9.5
| |