lkml.org 
[lkml]   [2013]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V synthetic keyboard
    On Wed, Sep 18, 2013 at 11:27:51PM +0000, KY Srinivasan wrote:
    >
    >
    > > -----Original Message-----
    > > From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
    > > Sent: Wednesday, September 18, 2013 2:01 PM
    > > To: KY Srinivasan
    > > Cc: gregkh@linuxfoundation.org; linux-kernel@vger.kernel.org;
    > > devel@linuxdriverproject.org; olaf@aepfle.de; apw@canonical.com;
    > > jasowang@redhat.com; dan.carpenter@oracle.com; linux-
    > > input@vger.kernel.org; vojtech@suse.cz
    > > Subject: Re: [PATCH V2 1/1] Drivers: input: serio: New driver to support Hyper-V
    > > synthetic keyboard
    > >
    > > Hi K.Y.,
    > >
    > > On Tue, Sep 17, 2013 at 04:26:58PM -0700, K. Y. Srinivasan wrote:
    > > > Add a new driver to support synthetic keyboard. On the next generation
    > > > Hyper-V guest firmware, many legacy devices will not be emulated and this
    > > > driver will be required.
    > > >
    > > > I would like to thank Vojtech Pavlik <vojtech@suse.cz> for helping me with the
    > > > details of the AT keyboard driver. I would also like to thank
    > > > Dan Carpenter <dan.carpenter@oracle.com> and
    > > > Dmitry Torokhov <dmitry.torokhov@gmail.com> for their detailed review of
    > > this
    > > > driver.
    > > >
    > > > I have addressed all the comments of Dan and Dmitry in this version of
    > > > the patch
    > >
    > > This looks much better. Could you tell me if the patch below (on top of
    > > yours) still works?
    > >
    > > Thanks.
    >
    > Thank you. The code looks much better now. You forgot to initialize the port_data and
    > after I fixed that everything seems to work as it did before: Here is the patch I used:

    Excellent, thank you for trying it out. I folded it all together and
    queued for 3.13.

    Thanks.

    --
    Dmitry


    \
     
     \ /
      Last update: 2013-09-19 18:21    [W:2.934 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site