Messages in this thread Patch in this message | | | Date | Thu, 19 Sep 2013 11:22:27 -0400 | From | Benjamin Poirier <> | Subject | Re: [PATCH]kconfig/menu.c: fix uninitialized variable warning |
| |
On 2013/09/19 12:58, Madhavan Srinivasan wrote: > In file included from scripts/kconfig/zconf.tab.c:2537:0: > scripts/kconfig/menu.c: In function ‘get_symbol_str’: > scripts/kconfig/menu.c:586:18: warning: ‘jump’ may be used uninitialized in > this function [-Wmaybe-uninitialized] ^^^^^
from gcc(1): "These warnings are made optional because GCC is not smart enough to see all the reasons why the code might be correct despite appearing to have an error."
I do not see this warning with gcc 4.7.2 or 4.8.1. Which version are you using?
The code does:
static void get_prompt_str(struct gstr *r, struct property *prop, [...] if (head && location) { jump = xmalloc(sizeof(struct jump_key)); [... different basic block ...] if (head && location && menu == location) jump->offset = r->len - 1;
If the second "if" is true, then the first one was true as well, and "jump" is initilized.
> jump->offset = r->len - 1; > ^ > scripts/kconfig/menu.c:547:19: note: ‘jump’ was declared here > struct jump_key *jump; > ^ > Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> > --- > scripts/kconfig/menu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c > index c1d5320..23b1827 100644 > --- a/scripts/kconfig/menu.c > +++ b/scripts/kconfig/menu.c > @@ -544,7 +544,7 @@ static void get_prompt_str(struct gstr *r, struct property *prop, > { > int i, j; > struct menu *submenu[8], *menu, *location = NULL; > - struct jump_key *jump; > + struct jump_key *jump = NULL; > > str_printf(r, _("Prompt: %s\n"), _(prop->text)); > menu = prop->menu->parent; > -- > 1.7.10.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |