Messages in this thread | | | Subject | Re: [PATCH 002/007] WAN Drivers: Update farsync driver and introduce fsflex driver | From | Joe Perches <> | Date | Wed, 18 Sep 2013 08:25:21 -0700 |
| |
On Wed, 2013-09-18 at 11:11 +0100, Kevin Curtis wrote: > Farsite Communications FarSync driver update [] > diff -uprN -X linux-3.10.1/Documentation/dontdiff linux-3.10.1/drivers/net/wan/uss_cmn.h linux-3.10.1_new/drivers/net/wan/uss_cmn.h
> +typedef enum _USS_COMMANDS {
I think this code would be more linux style without all the typedefs
> +typedef struct { [] > +} FLEX_SERCONF, *PFLEX_SERCONF;
> +typedef struct { [] > +} FLEX_CARD_INFO, *PFLEX_CARD_INFO; /* sizeof(FLEX_CARD_INFO) = 128 */
> +typedef struct { [] > +} FLEX_USB_STATS, *PFLEX_USB_STATS;
> +typedef struct _INTERFACE_RECORD { [] > +} IR, *PIR;
> +typedef struct _INTERFACE_RECORD_EX { [] > +} IREX, *PIREX;
| |