lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dma/Kconfig: Make TI_EDMA select TI_PRIV_EDMA
On Wed, Sep 04, 2013 at 12:10:45PM -0400, Josh Boyer wrote:
> On Wed, Sep 04, 2013 at 09:32:03AM -0400, Josh Boyer wrote:
> > The TI_EDMA driver unconditionally calls functions provided by the
> > TI_PRIV_EDMA code, but it doesn't force that to be built-in. If that isn't
> > otherwise enabled somewhere, you can get build errors like:
> >
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:593: undefined reference to `edma_free_slot'
> > drivers/built-in.o: In function `edma_terminate_all':
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:169: undefined reference to `edma_stop'
> > drivers/built-in.o: In function `edma_execute':
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:122: undefined reference to `edma_write_slot'
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:149: undefined reference to `edma_link'
> > linux-3.12.0-0.rc0.git1.1.fc21.armv7hl/drivers/dma/edma.c:152: undefined reference to `edma_start'
> >
> > Make TI_EDMA select TI_PRIV_EDMA to avoid this.
> >
> > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Applied, thanks

~Vinod
>
> Just replying to Matt's new email address as the TI one bounced when I
> originally sent this.
>
> > ---
> > drivers/dma/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> > index daa4da2..825374b 100644
> > --- a/drivers/dma/Kconfig
> > +++ b/drivers/dma/Kconfig
> > @@ -198,6 +198,7 @@ config TI_EDMA
> > depends on ARCH_DAVINCI || ARCH_OMAP
> > select DMA_ENGINE
> > select DMA_VIRTUAL_CHANNELS
> > + select TI_PRIV_EDMA
> > default n
> > help
> > Enable support for the TI EDMA controller. This DMA
> > --
> > 1.8.3.1
> >

--


\
 
 \ /
  Last update: 2013-09-17 08:01    [W:0.052 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site