lkml.org 
[lkml]   [2013]   [Sep]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 02/11] 9p: fix dentry leak in v9fs_vfs_atomic_open_dotl()
From
On Tue, Sep 17, 2013 at 1:28 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Mon, Sep 16, 2013 at 11:02:41PM +0100, Al Viro wrote:
>> On Mon, Sep 16, 2013 at 10:09:46PM +0200, Miklos Szeredi wrote:
>>
>> > > I would definitely prefer EEXIST logics dealt with in fs/namei.c - if nothing
>> > > else, it had been done wrong in too many instances...
>> >
>> > Okay.
>>
>> OK, so I'm taking 1, 5, 9, 10, 11, then add check to fs/namei.c:atomic_open(),
>> leaving the rest of gfs2 ones for gfs2 tree... Give me a few and I'll push
>> that.
>
> Pushed (head at d332c7). That should cover 9p and fuse as well, AFAICS.
> Do you have any problems with that variant?

Just one. This needs to be removed, since this condition is now
explicitly allowed and later checked for:

if (WARN_ON(excl && !(*opened & FILE_CREATED)))
*opened |= FILE_CREATED;

Thanks,
Miklos


\
 
 \ /
  Last update: 2013-09-17 12:41    [W:0.073 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site