| Date | Mon, 16 Sep 2013 14:36:45 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 07/50] mm: Account for a THP NUMA hinting update as one PTE update |
| |
On Tue, Sep 10, 2013 at 10:31:47AM +0100, Mel Gorman wrote: > A THP PMD update is accounted for as 512 pages updated in vmstat. This is > large difference when estimating the cost of automatic NUMA balancing and > can be misleading when comparing results that had collapsed versus split > THP. This patch addresses the accounting issue. > > Signed-off-by: Mel Gorman <mgorman@suse.de> > --- > mm/mprotect.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 94722a4..2bbb648 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -145,7 +145,7 @@ static inline unsigned long change_pmd_range(struct vm_area_struct *vma, > split_huge_page_pmd(vma, addr, pmd); > else if (change_huge_pmd(vma, pmd, addr, newprot, > prot_numa)) { > - pages += HPAGE_PMD_NR; > + pages++;
But now you're not counting pages anymore..
|