Messages in this thread | | | Date | Sat, 14 Sep 2013 09:41:51 +0200 | From | Vladimir Murzin <> | Subject | Re: [PATCH 211/228] cpufreq: tegra: remove calls to cpufreq_notify_transition() |
| |
On Sat, Sep 14, 2013 at 09:39:31AM +0530, Viresh Kumar wrote: > On 14 September 2013 04:22, Stephen Warren <swarren@wwwdotorg.org> wrote: > > I wonder if this series is bisectable? Perhaps I should just go and read > > the rest of the series, but I presume there's a patch somewhere else > > that adds those two cpufreq_notify_transition() to the cpufreq core. > > Either that happens before this patch (in which case listeners will get > > two notifications each time; perhaps that is safe?), or after this patch > > (in which case with just this patch applied, no notifications will be > > sent until a later patch! > > Hmm.. Good Catch.. > > So, yes git bisect would be compilable but not runnable.. As we are > already serialized notifications and so two PRE notifications will > generate a crash.. > > But I don't want to get all that in a single patch as that would be: > > 40 files changed, 192 insertions(+), 623 deletions(-) > > And that would be hard to review it.. > > Any suggestions? >
It reminds me time of removing CONFIG_HOTPLUG and following __dev* attributes. At least stats for 48c68c4 "Drivers: video: remove __dev* attributes" is:
135 files changed, 1017 insertions(+), 1129 deletions(-)
Maybe coccinelle script, which maintainers could run it on their trees, would help?
Vladimir
> > Aside from that, all the Tegra-specific patches in this series, > > Acked-by: Stephen Warren <swarren@nvidia.com> > > Thanks.. > > _______________________________________________ > linaro-kernel mailing list > linaro-kernel@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-kernel
| |