lkml.org 
[lkml]   [2013]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 1/4] skd: use regular version of copy_from_user()
The other __copy_from_user() calls have access_ok() checks so they are
fine, but these two don't have the check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
index 6fc0296..dfd05a9 100644
--- a/drivers/block/skd_main.c
+++ b/drivers/block/skd_main.c
@@ -1736,7 +1736,7 @@ static int skd_sg_io_get_and_check_args(struct skd_device *skdev,
return -EINVAL;
}

- if (__copy_from_user(sksgio->cdb, sgp->cmdp, sgp->cmd_len)) {
+ if (copy_from_user(sksgio->cdb, sgp->cmdp, sgp->cmd_len)) {
DPRINTK(skdev, "copy_from_user cmdp failed %p\n", sgp->cmdp);
return -EFAULT;
}
@@ -1767,7 +1767,7 @@ static int skd_sg_io_get_and_check_args(struct skd_device *skdev,
sksgio->iov = iov;
sksgio->iovcnt = sgp->iovec_count;

- if (__copy_from_user(iov, sgp->dxferp, nbytes)) {
+ if (copy_from_user(iov, sgp->dxferp, nbytes)) {
DPRINTK(skdev, "copy_from_user iovec failed %p\n",
sgp->dxferp);
return -EFAULT;

\
 
 \ /
  Last update: 2013-09-13 10:01    [W:0.030 / U:1.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site