lkml.org 
[lkml]   [2013]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 184/228] cpufreq: at32ap: remove calls to cpufreq_notify_transition()
    Date
    Most of the drivers do following in their ->target_index() routines:

    struct cpufreq_freqs freqs;
    freqs.old = old freq...
    freqs.new = new freq...

    cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);

    /* Change rate here */

    cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);

    This is replicated over all cpufreq drivers today and there doesn't exists a
    good enough reason why this shouldn't be moved to cpufreq core instead.

    Earlier patches have added support in cpufreq core to do cpufreq notification on
    frequency change, this one removes it from this driver.

    Some related minor cleanups are also done along with it.

    Acked-by: Hans-Christian Egtvedt <egtvedt@samfundet.no>
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    ---
    drivers/cpufreq/at32ap-cpufreq.c | 22 +++++++++-------------
    1 file changed, 9 insertions(+), 13 deletions(-)

    diff --git a/drivers/cpufreq/at32ap-cpufreq.c b/drivers/cpufreq/at32ap-cpufreq.c
    index 81d0752..856ad80 100644
    --- a/drivers/cpufreq/at32ap-cpufreq.c
    +++ b/drivers/cpufreq/at32ap-cpufreq.c
    @@ -37,27 +37,23 @@ static unsigned long loops_per_jiffy_ref;

    static int at32_set_target(struct cpufreq_policy *policy, unsigned int index)
    {
    - struct cpufreq_freqs freqs;
    + unsigned int old_freq, new_freq;

    - freqs.old = at32_get_speed(0);
    - freqs.new = freq_table[index].frequency;
    + old_freq = at32_get_speed(0);
    + new_freq = freq_table[index].frequency;

    if (!ref_freq) {
    - ref_freq = freqs.old;
    + ref_freq = old_freq;
    loops_per_jiffy_ref = boot_cpu_data.loops_per_jiffy;
    }

    - cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);
    - if (freqs.old < freqs.new)
    + if (old_freq < new_freq)
    boot_cpu_data.loops_per_jiffy = cpufreq_scale(
    - loops_per_jiffy_ref, ref_freq, freqs.new);
    - clk_set_rate(cpuclk, freqs.new * 1000);
    - if (freqs.new < freqs.old)
    + loops_per_jiffy_ref, ref_freq, new_freq);
    + clk_set_rate(cpuclk, new_freq * 1000);
    + if (new_freq < old_freq)
    boot_cpu_data.loops_per_jiffy = cpufreq_scale(
    - loops_per_jiffy_ref, ref_freq, freqs.new);
    - cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
    -
    - pr_debug("cpufreq: set frequency %u Hz\n", freqs.new * 1000);
    + loops_per_jiffy_ref, ref_freq, new_freq);

    return 0;
    }
    --
    1.7.12.rc2.18.g61b472e


    \
     
     \ /
      Last update: 2013-09-13 16:01    [W:4.082 / U:0.112 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site