lkml.org 
[lkml]   [2013]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 09/16] Drivers: hv: vmbus: Fix a bug in the handling of channel offers
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "K. Y. Srinivasan" <kys@microsoft.com>

    commit 42dceebe34600b2d02a38baa3e869009ba3d14c7 upstream.

    The channel state should be correctly set before registering the device. In the current
    code the driver probe would fail for channels that have been rescinded and subsequently
    re-offered. Fix the bug.

    Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/hv/channel_mgmt.c | 14 +++++++-------
    1 file changed, 7 insertions(+), 7 deletions(-)

    --- a/drivers/hv/channel_mgmt.c
    +++ b/drivers/hv/channel_mgmt.c
    @@ -262,6 +262,13 @@ static void vmbus_process_offer(struct w
    }

    /*
    + * This state is used to indicate a successful open
    + * so that when we do close the channel normally, we
    + * can cleanup properly
    + */
    + newchannel->state = CHANNEL_OPEN_STATE;
    +
    + /*
    * Start the process of binding this offer to the driver
    * We need to set the DeviceObject field before calling
    * vmbus_child_dev_add()
    @@ -287,13 +294,6 @@ static void vmbus_process_offer(struct w
    kfree(newchannel->device_obj);

    free_channel(newchannel);
    - } else {
    - /*
    - * This state is used to indicate a successful open
    - * so that when we do close the channel normally, we
    - * can cleanup properly
    - */
    - newchannel->state = CHANNEL_OPEN_STATE;
    }
    }




    \
     
     \ /
      Last update: 2013-09-13 09:41    [W:2.739 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site