lkml.org 
[lkml]   [2013]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH v2 3/9] x86, dma: Support allocate memory from bottom upwards in dma_contiguous_reserve().
Hi Toshi,

On 09/13/2013 03:22 AM, Toshi Kani wrote:
......
>> + if (memblock_direction_bottom_up()) {
>> + addr = memblock_alloc_bottom_up(
>> + MEMBLOCK_ALLOC_ACCESSIBLE,
>> + limit, size, alignment);
>> + if (addr)
>> + goto success;
>> + }
>
> I am afraid that this version went to a wrong direction. Allocating
> from the bottom up needs to be an internal logic within the memblock
> allocator. It should not require the callers to be aware of the
> direction and make a special request.
>

I think my v1 patch-set was trying to do so. Was it too complicated ?

So just move this logic to memblock_find_in_range_node(), is this OK ?

Thanks.



\
 
 \ /
  Last update: 2013-09-13 06:01    [W:0.178 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site