lkml.org 
[lkml]   [2013]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firmware: Be a bit more verbose about direct firmware loading failure
On Thu, Sep 12, 2013 at 10:30:59PM +0800, Ming Lei wrote:
> On Thu, Sep 12, 2013 at 9:16 PM, Neil Horman <nhorman@tuxdriver.com> wrote:
> >>
> > Please re-read the patch, then point out to me which printk the above action
> > will trigger, because its not happening in my testing. If you'll take a look at
> > fw_get_filesystem_firmware, you'll see that if the filp_open on a firmware file
> > fails, we continue the for loop through the list of available search paths. No
> > error is generated in the case you describe above.
>
> You are right, sorry for missing "if (IS_ERR(file)) continue;", and looks the
> patch is good.
>
> Acked-by: Ming Lei <ming.lei@canonical.com>
>
> Thanks,
Awesome, thanks!
Neil

> --
> Ming Lei
>


\
 
 \ /
  Last update: 2013-09-12 17:21    [W:0.052 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site