lkml.org 
[lkml]   [2013]   [Sep]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 41/50] sched: numa: Use {cpu, pid} to create task groups for shared faults
On Thu, Sep 12, 2013 at 08:42:18PM +0800, Hillf Danton wrote:
> Hello Mel
>
> On Tue, Sep 10, 2013 at 5:32 PM, Mel Gorman <mgorman@suse.de> wrote:
> >
> > +void task_numa_free(struct task_struct *p)
> > +{
> > + struct numa_group *grp = p->numa_group;
> > + int i;
> > +
> > + kfree(p->numa_faults);
> > +
> > + if (grp) {
> > + for (i = 0; i < 2*nr_node_ids; i++)
> > + atomic_long_sub(p->numa_faults[i], &grp->faults[i]);
> > +
> use after free, numa_faults ;/
>

It gets fixed in the patch "sched: numa: use group fault statistics in
numa placement" but I agree that it's the wrong place to fix it.

--
Mel Gorman
SUSE Labs


\
 
 \ /
  Last update: 2013-09-12 17:21    [W:0.705 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site