lkml.org 
[lkml]   [2013]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] sysfs: @name comes before @ns
Hello, Eric.

On Wed, Sep 11, 2013 at 08:39:27PM -0700, Eric W. Biederman wrote:
> @ns is more significant so it should come first.
>
> Where do we have the backwards convention of putting @name first?

Because @ns is optional and you end up with stupid stuff like

sysfs_xxx_ns(@param, @ns, @name)
sysfs_xxx(@param, @name)

You put optional params after the mandatory ones. It may be difficult
to accept for you but @ns is a *clearly* optional thing for sysfs.

--
tejun


\
 
 \ /
  Last update: 2013-09-12 06:01    [W:0.089 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site