lkml.org 
[lkml]   [2013]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[163/251] net_sched: info leak in atm_tc_dump_class()
    3.6.11.9-rc1 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    [ Upstream commit 8cb3b9c3642c0263d48f31d525bcee7170eedc20 ]

    The "pvc" struct has a hole after pvc.sap_family which is not cleared.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Reviewed-by: Jiri Pirko <jiri@resnulli.us>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    net/sched/sch_atm.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/net/sched/sch_atm.c b/net/sched/sch_atm.c
    index ca8e0a5..1f9c314 100644
    --- a/net/sched/sch_atm.c
    +++ b/net/sched/sch_atm.c
    @@ -605,6 +605,7 @@ static int atm_tc_dump_class(struct Qdisc *sch, unsigned long cl,
    struct sockaddr_atmpvc pvc;
    int state;

    + memset(&pvc, 0, sizeof(pvc));
    pvc.sap_family = AF_ATMPVC;
    pvc.sap_addr.itf = flow->vcc->dev ? flow->vcc->dev->number : -1;
    pvc.sap_addr.vpi = flow->vcc->vpi;
    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-09-11 08:21    [W:2.632 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site