lkml.org 
[lkml]   [2013]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[199/251] genetlink: fix family dump race
    3.6.11.9-rc1 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Johannes Berg <johannes.berg@intel.com>

    [ Upstream commit 58ad436fcf49810aa006016107f494c9ac9013db ]

    When dumping generic netlink families, only the first dump call
    is locked with genl_lock(), which protects the list of families,
    and thus subsequent calls can access the data without locking,
    racing against family addition/removal. This can cause a crash.
    Fix it - the locking needs to be conditional because the first
    time around it's already locked.

    A similar bug was reported to me on an old kernel (3.4.47) but
    the exact scenario that happened there is no longer possible,
    on those kernels the first round wasn't locked either. Looking
    at the current code I found the race described above, which had
    also existed on the old kernel.

    Cc: stable@vger.kernel.org
    Reported-by: Andrei Otcheretianski <andrei.otcheretianski@intel.com>
    Signed-off-by: Johannes Berg <johannes.berg@intel.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    net/netlink/genetlink.c | 7 +++++++
    1 file changed, 7 insertions(+)

    diff --git a/net/netlink/genetlink.c b/net/netlink/genetlink.c
    index 42556ce..17e7104 100644
    --- a/net/netlink/genetlink.c
    +++ b/net/netlink/genetlink.c
    @@ -749,6 +749,10 @@ static int ctrl_dumpfamily(struct sk_buff *skb, struct netlink_callback *cb)
    struct net *net = sock_net(skb->sk);
    int chains_to_skip = cb->args[0];
    int fams_to_skip = cb->args[1];
    + bool need_locking = chains_to_skip || fams_to_skip;
    +
    + if (need_locking)
    + genl_lock();

    for (i = chains_to_skip; i < GENL_FAM_TAB_SIZE; i++) {
    n = 0;
    @@ -770,6 +774,9 @@ errout:
    cb->args[0] = i;
    cb->args[1] = n;

    + if (need_locking)
    + genl_unlock();
    +
    return skb->len;
    }

    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-09-11 08:21    [W:4.029 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site