lkml.org 
[lkml]   [2013]   [Sep]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[220/251] ARM: davinci: nand: specify ecc strength
    3.6.11.9-rc1 stable review patch.
    If anyone has any objections, please let me know.

    ------------------

    From: Sekhar Nori <nsekhar@ti.com>

    [ Upstream commit acd36357edc08649e85ff15dc4ed62353c912eff ]

    Starting with kernel v3.5, it is mandatory
    to specify ECC strength when using hardware
    ECC. Without this, kernel panics with a warning
    of the sort:

    Driver must set ecc.strength when using hardware ECC
    ------------[ cut here ]------------
    kernel BUG at drivers/mtd/nand/nand_base.c:3519!

    Fix this by specifying ECC strength for the boards
    which were missing this.

    Reported-by: Holger Freyther <holger@freyther.de>
    Cc: <stable@vger.kernel.org> #v3.5+
    Signed-off-by: Sekhar Nori <nsekhar@ti.com>
    Signed-off-by: Kevin Hilman <khilman@linaro.org>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    arch/arm/mach-davinci/board-dm355-leopard.c | 1 +
    arch/arm/mach-davinci/board-dm644x-evm.c | 1 +
    arch/arm/mach-davinci/board-dm646x-evm.c | 1 +
    arch/arm/mach-davinci/board-neuros-osd2.c | 1 +
    4 files changed, 4 insertions(+)

    diff --git a/arch/arm/mach-davinci/board-dm355-leopard.c b/arch/arm/mach-davinci/board-dm355-leopard.c
    index 8e77032..eeeb81f 100644
    --- a/arch/arm/mach-davinci/board-dm355-leopard.c
    +++ b/arch/arm/mach-davinci/board-dm355-leopard.c
    @@ -75,6 +75,7 @@ static struct davinci_nand_pdata davinci_nand_data = {
    .parts = davinci_nand_partitions,
    .nr_parts = ARRAY_SIZE(davinci_nand_partitions),
    .ecc_mode = NAND_ECC_HW_SYNDROME,
    + .ecc_bits = 4,
    .bbt_options = NAND_BBT_USE_FLASH,
    };

    diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
    index d34ed55..87a904f 100644
    --- a/arch/arm/mach-davinci/board-dm644x-evm.c
    +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
    @@ -152,6 +152,7 @@ static struct davinci_nand_pdata davinci_evm_nandflash_data = {
    .parts = davinci_evm_nandflash_partition,
    .nr_parts = ARRAY_SIZE(davinci_evm_nandflash_partition),
    .ecc_mode = NAND_ECC_HW,
    + .ecc_bits = 1,
    .bbt_options = NAND_BBT_USE_FLASH,
    .timing = &davinci_evm_nandflash_timing,
    };
    diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
    index 958679a..5d4b51f 100644
    --- a/arch/arm/mach-davinci/board-dm646x-evm.c
    +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
    @@ -89,6 +89,7 @@ static struct davinci_nand_pdata davinci_nand_data = {
    .parts = davinci_nand_partitions,
    .nr_parts = ARRAY_SIZE(davinci_nand_partitions),
    .ecc_mode = NAND_ECC_HW,
    + .ecc_bits = 1,
    .options = 0,
    };

    diff --git a/arch/arm/mach-davinci/board-neuros-osd2.c b/arch/arm/mach-davinci/board-neuros-osd2.c
    index f6b9fc7..58d902a 100644
    --- a/arch/arm/mach-davinci/board-neuros-osd2.c
    +++ b/arch/arm/mach-davinci/board-neuros-osd2.c
    @@ -88,6 +88,7 @@ static struct davinci_nand_pdata davinci_ntosd2_nandflash_data = {
    .parts = davinci_ntosd2_nandflash_partition,
    .nr_parts = ARRAY_SIZE(davinci_ntosd2_nandflash_partition),
    .ecc_mode = NAND_ECC_HW,
    + .ecc_bits = 1,
    .bbt_options = NAND_BBT_USE_FLASH,
    };

    --
    1.7.10.4



    \
     
     \ /
      Last update: 2013-09-11 07:41    [W:4.085 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site