lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] staging: usbip: stub_main: correctly handle return value
On Tue, Sep 10, 2013 at 10:44:07AM +0530, navin patidar wrote:
> ret == 0 means success, anything else is failure.
>

Hopefully, it's only returning negative error codes. Otherwise it needs
a different fix.

There isn't an official kernel style on if "if (ret < 0)" is better than
"if (ret)". Some subsystems have a preference but most don't care.
It's up to the maintainer to choose.

Your patch is fine, but the changelog is misleading. It should just say
"I prefer the other style" instead of "This code is wrong and has buggy
error handling".

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-09-10 23:21    [W:0.268 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site