lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf/x86: fix uncore PCI fixed counter handling
On Mon, Sep 09, 2013 at 12:53:50PM -0700, Stephane Eranian wrote:
>
> There was a bug in the handling of SNB-EP/IVB-EP uncore PCI
> fixed counters, e.g., IMC. It would cause erratic values to
> be returned for the IMC clockticks event. This was due to
> a bogus hwc->config value which was then written to PCI
> config space. The fixed counter has most fields marked as
> reserved with hw reset values of 0. Yet the kernel was
> defaulting to a hwc->config = ~0 and that was causing
> the issues. The patch sets the hwc->config values for fixed
> uncore event to 0. Now, the values of imc clockticks is
> correct.
>
> $ perf stat -a -C 0 -e uncore_imc_0/clockticks/ -I 1000 sleep 10

Looks good to me.

Reviewed-by: Andi Kleen <ak@linux.intel.com>

-Andi


\
 
 \ /
  Last update: 2013-09-10 22:41    [W:0.047 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site