lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 7/7] sched, x86: Optimize the preempt_schedule() call
>>> On 10.09.13 at 15:42, Ingo Molnar <mingo@kernel.org> wrote:

> * Peter Zijlstra <peterz@infradead.org> wrote:
>
>> + .macro SAVE_ALL
>> + pushl_cfi %eax
>> + CFI_REL_OFFSET eax, 0
>> + pushl_cfi %ebp
>> + CFI_REL_OFFSET ebp, 0
>> + pushl_cfi %edi
>> + CFI_REL_OFFSET edi, 0
>> + pushl_cfi %esi
>> + CFI_REL_OFFSET esi, 0
>> + pushl_cfi %edx
>> + CFI_REL_OFFSET edx, 0
>> + pushl_cfi %ecx
>> + CFI_REL_OFFSET ecx, 0
>> + pushl_cfi %ebx
>> + CFI_REL_OFFSET ebx, 0
>> + .endm
>> +
>> + .macro RESTORE_ALL
>> + popl_cfi %ebx
>> + CFI_RESTORE ebx
>> + popl_cfi %ecx
>> + CFI_RESTORE ecx
>> + popl_cfi %edx
>> + CFI_RESTORE edx
>> + popl_cfi %esi
>> + CFI_RESTORE esi
>> + popl_cfi %edi
>> + CFI_RESTORE edi
>> + popl_cfi %ebp
>> + CFI_RESTORE ebp
>> + popl_cfi %eax
>> + CFI_RESTORE eax
>> + .endm
>
> Side note: shouldn't the pushl_cfi and popl_cfi macros be adjusted,
> instead of open coding it?

If you mean the open coding of CFI_REL_OFFSET and CFI_RESTORE,
then no - there may be pushes/pops that don't save the caller's
register values (i.e. where solely the frame pointer adjustment
matters).

If you meant something else, please clarify what.

Jan



\
 
 \ /
  Last update: 2013-09-10 16:21    [W:0.317 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site