lkml.org 
[lkml]   [2013]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] Documentation: dt: hwmon: add OF document for LM90
On 09/10/2013 06:14 AM, Stephen Warren wrote:
> On 09/09/2013 04:52 AM, Guenter Roeck wrote:
>> On 09/09/2013 03:29 AM, Wei Ni wrote:
>>> Add OF document for LM90 in Documentation/devicetree/.
>
>>> diff --git a/Documentation/devicetree/bindings/hwmon/lm90.txt
>
>>> +* LM90 series thermometer.
>>> +
>>> +Required node properties:
>>> +- compatible: manufacture and chip name, one of
>>
>> manufacturer
>>
>>> + "<manufacture>,adm1032"
> ...
>>> + "<manufacture>,sa56004"
>>
>> Shouldn't the manufacturers be listed explicitly ?
>
> Yes, and they must all be present in
> Documentation/devicetree/bindings/vendor-prefixes.txt.

Oh, got it, I will update it, thanks.

>
>>> +Example LM90 node:
>>> +
>>> +temp-sensor {
>>> + compatible = "onnn,nct1008";
>>> + reg = <0x4c>;
>>> + vcc-supply = <&palmas_ldo6_reg>;
>>> + interrupt-parent = <&gpio>;
>>
>> List above as optional property.
>
> I believe it's common not to document this, since it's implicitly
> supported as part of any node that is an interrupt source.
>



\
 
 \ /
  Last update: 2013-09-10 06:41    [W:1.640 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site