lkml.org 
[lkml]   [2013]   [Aug]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 6/6] usb: host: tegra: Tegra30 support
On Tue, Aug 06, 2013 at 11:27:11PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 08/06/2013 11:16 PM, Tuomas Tynkkynen wrote:
>
> >[...]
>
> >>>+ match = of_match_device(tegra_ehci_of_match, &pdev->dev);
> >>>+ if (!match) {
> >>>+ dev_err(&pdev->dev, "Error: No device match found\n");
> >>>+ return -ENODEV;
> >>>+ }
> >>>+ soc_config = (struct tegra_ehci_soc_config *)match->data;
>
> >> Aren't casts from 'const void *' automatic?
>
> >>WBR, Sergei
>
> >Indeed they are, but those explicit casts seem to be used in many places in the kernel.
>
> I suspect people just don't know C well enough. They are also
> being gradually removed.

yeah, please resend with the cast removed. Also, put Tested-by, Acked-by
and Reviewed-by in place.

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-08-09 16:01    [W:0.132 / U:6.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site