lkml.org 
[lkml]   [2013]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] leds-pca9633: Add support for PCA9634
Hello,

> > Add support for PCA9634 chip, which belongs to the same family as the
> > 9633 but with support for 8 outputs instead of 4.

> Basically I like this method to add a new chip supporting. Please find
> my comments below.

me too :)

> What about just rename the whole file to leds-pca963x.c. And rename
> some pca9633 to pca963x in the driver.

there are other, similar I2C LED driver chips which might be
handled with the current pca9633 driver, e.g. the pca9685 (which is
supported under pwm/ by the way)

people have argued that the numbering scheme of chips is hard to
predict; hence, the driver name should be determined by the first
device supported to avoid subsequent renaming -- but I have no strong
feelings about this

regards, p.

--

Peter Meerwald
+43-664-2444418 (mobile)


\
 
 \ /
  Last update: 2013-08-09 01:01    [W:0.074 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site