lkml.org 
[lkml]   [2013]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 06/11] tracing: add 'enable_event' and 'disable_event' event trigger commands
(2013/07/30 1:41), Tom Zanussi wrote:
> +
> +static int
> +event_enable_trigger_func(struct event_command *cmd_ops, void *cmd_data,
> + char *glob, char *cmd, char *param, int enabled)
> +{
> + struct trace_array *tr = top_trace_array();

OK, here is the problem. top_trace_array() always returns the default
instance. So, following change will solve the problem.

struct trigger_iterator *iter = cmd_data;
struct trace_array *tr = iter->file->tr;

However, I think we still have a race problem on accessing event_file.

Thank you,

--
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com




\
 
 \ /
  Last update: 2013-08-08 08:01    [W:0.115 / U:0.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site