Messages in this thread | | | Date | Thu, 08 Aug 2013 14:54:20 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH v4 06/11] tracing: add 'enable_event' and 'disable_event' event trigger commands |
| |
(2013/07/30 1:41), Tom Zanussi wrote: > + > +static int > +event_enable_trigger_func(struct event_command *cmd_ops, void *cmd_data, > + char *glob, char *cmd, char *param, int enabled) > +{ > + struct trace_array *tr = top_trace_array();
OK, here is the problem. top_trace_array() always returns the default instance. So, following change will solve the problem.
struct trigger_iterator *iter = cmd_data; struct trace_array *tr = iter->file->tr;
However, I think we still have a race problem on accessing event_file.
Thank you,
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |