lkml.org 
[lkml]   [2013]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/2] ALSA: Added jack detection KControl support
At Wed, 7 Aug 2013 17:45:09 +0100,
Mark Brown wrote:
>
> On Fri, Aug 02, 2013 at 12:59:24AM -0700, Felipe F. Tonello wrote:
>
> > +int jack_ctl_integer_info(struct snd_kcontrol *kcontrol,
> > + struct snd_ctl_elem_info *uinfo)
> > +{
> > + uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
> > + uinfo->count = 0x10000U;
> > + uinfo->value.integer.min = 0;
> > + uinfo->value.integer.max = 0xffff;
> > + return 0;
> > +}
>
> I'd expected to see us creating multiple boolean controls here. I don't
> have a great problem with doing things this way but it's surprising and
> I worry about confusing existing userspace, Takashi?

Yes, multiple boolean would make more sense.


thanks,

Takashi


\
 
 \ /
  Last update: 2013-08-08 08:01    [W:0.070 / U:3.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site