[lkml]   [2013]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 43/47] perf ui/gtk: Fix segmentation fault on perf_hpp__for_each_format loop
From: Namhyung Kim <>

The commit 2b8bfa6bb8a7 ("perf tools: Centralize default columns init in
perf_hpp__init") moves initialization of common overhead column to
perf_hpp__init() but forgot about the gtk code.

So the gtk code added the same column to the list twice causing infinite
loop when iterating it by perf_hpp__for_each_format loop. When I run
perf report --gtk, I can see following messages indefinitely.

(perf:11687): Gtk-CRITICAL **: IA__gtk_main_quit: assertion 'main_loops != NULL' failed
perf: Segmentation fault

Signed-off-by: Namhyung Kim <>
Reviewed-by: Pekka Enberg <>
Cc: Andi Kleen <>
Cc: Christoph Hellwig <>
Cc: Ingo Molnar <>
Cc: Jiri Olsa <>
Cc: Paul Mackerras <>
Cc: Pekka Enberg <>
Cc: Peter Zijlstra <>
Signed-off-by: Arnaldo Carvalho de Melo <>
tools/perf/ui/gtk/hists.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/tools/perf/ui/gtk/hists.c b/tools/perf/ui/gtk/hists.c
index cb2ed198..2ca66cc 100644
--- a/tools/perf/ui/gtk/hists.c
+++ b/tools/perf/ui/gtk/hists.c
@@ -109,8 +109,6 @@ __HPP_COLOR_PERCENT_FN(overhead_guest_us, period_guest_us)

void perf_gtk__init_hpp(void)
- perf_hpp__column_enable(PERF_HPP__OVERHEAD);

perf_hpp__format[PERF_HPP__OVERHEAD].color =

 \ /
  Last update: 2013-08-08 04:01    [W:0.199 / U:1.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site