Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: OPP: rename functions? (was [PATCH] OPP: Export opp_add()) | Date | Thu, 08 Aug 2013 00:53:46 +0200 |
| |
On Wednesday, August 07, 2013 10:48:54 AM Nishanth Menon wrote: > Rafael, > offline question:
Not really offline. :-)
> On 08/06/2013 09:15 AM, Rafael J. Wysocki wrote: > > On Tuesday, August 06, 2013 08:08:20 AM Nishanth Menon wrote: > >> change in subject to reflect new discussion. > >> > >> On 05:53-20130806, Randy Dunlap wrote: > >>> On 08/03/2013 02:25 AM, Viresh Kumar wrote: > > >>>> +EXPORT_SYMBOL_GPL(opp_add); > >>> > >>> Could it be renamed to pm_opp_add() or power_opp_add() ? > >>> The name is a bit too unspecific IMO. > >> Though this has nothing specific with this patch, an interesting point. > >> > >> git grep -w opp . showed drivers/tty/n_tty.c, > >> drivers/sbus/char/openprom.c and arch/powerpc/kvm/mpic.c using > >> variables named opp to mean what ever they had in context. rest(around > >> 40 odd files) seem to use opp as in Documentation/power/opp.txt.. > >> > >> We could go with a pm_ prefix or even dev_pm_opp_ prefix to be more > >> specific, though I prefer just pm_. If Rafael and others are ok, I can > >> post a series out. > > > > Yup, that would be useful. I'm for dev_pm_opp_ if that matters. > > Given that there would be quiet a few conflicts, do you have a > suggestion around what baseline I should submit this?
Well, ideally, on top of 3.12-rc1 when it's out and put it into linux-next right after that.
Thanks, Rafael
| |