lkml.org 
[lkml]   [2013]   [Aug]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/1] input: ideapad_slidebar: new input driver
Hi Andrey,

On Wed, Aug 07, 2013 at 03:25:34PM +0400, Andrey Moiseev wrote:
> +/* Keyboard handler */
> +static irq_handler_t kbd_irq_handler(int irq, void *dev_id,
> + struct pt_regs *regs)
> +{
> + /* Scancodes: e03b on move, bb on release */
> + int scancode = inb(0x60);

No, you should not just read KBC data without regard to what other
parts of kernel are doing (i8042 might be accessing it at the same time
because AUX IRQ was raised).

This driver has to be implemented as i8042 filter.

Thanks.

--
Dmitry


\
 
 \ /
  Last update: 2013-08-07 21:01    [W:0.044 / U:2.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site