lkml.org 
[lkml]   [2013]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 1/2] kernel/sys.c: return the current gid when error occurs
According to the API definition, when error occurs, need return current
fsgid instead of the previous one.

The related informations ("man setfsgid"):

RETURN VALUE
On success, the previous value of fsgid is returned. On error, the current value of fsgid is returned.

Signed-off-by: Chen Gang <gang.chen@asianux.com>
---
kernel/sys.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index 771129b..9356dc8 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -775,11 +775,11 @@ SYSCALL_DEFINE1(setfsgid, gid_t, gid)

kgid = make_kgid(old->user_ns, gid);
if (!gid_valid(kgid))
- return old_fsgid;
+ return gid;

new = prepare_creds();
if (!new)
- return old_fsgid;
+ return gid;

if (gid_eq(kgid, old->gid) || gid_eq(kgid, old->egid) ||
gid_eq(kgid, old->sgid) || gid_eq(kgid, old->fsgid) ||
@@ -791,7 +791,7 @@ SYSCALL_DEFINE1(setfsgid, gid_t, gid)
}

abort_creds(new);
- return old_fsgid;
+ return gid;

change_okay:
commit_creds(new);
--
1.7.7.6

\
 
 \ /
  Last update: 2013-08-06 10:21    [W:0.166 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site