Messages in this thread | | | Subject | Re: [PATCH v2 RESEND 04/18] acpi: Introduce acpi_verify_initrd() to check if a table is invalid. | From | Toshi Kani <> | Date | Tue, 06 Aug 2013 17:02:34 -0600 |
| |
On Fri, 2013-08-02 at 17:14 +0800, Tang Chen wrote: > In acpi_initrd_override(), it checks several things to ensure the > table it found is valid. In later patches, we need to do these check > somewhere else. So this patch introduces a common function > acpi_verify_initrd() to do all these checks, and reuse it in different
Typo: acpi_verify_initrd() -> acpi_verify_table()
-Toshi
> places. The function will be used in the subsequent patches. > > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com> > Reviewed-by: Zhang Yanfei <zhangyanfei@cn.fujitsu.com> > Acked-by: Toshi Kani <toshi.kani@hp.com> > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > --- > drivers/acpi/osl.c | 86 +++++++++++++++++++++++++++++++++++++--------------- > 1 files changed, 61 insertions(+), 25 deletions(-) > > diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c > index 3b8bab2..0043e9f 100644 > --- a/drivers/acpi/osl.c > +++ b/drivers/acpi/osl.c > @@ -572,9 +572,68 @@ static const char * const table_sigs[] = { > /* Must not increase 10 or needs code modification below */ > #define ACPI_OVERRIDE_TABLES 10 > > +/******************************************************************************* > + * > + * FUNCTION: acpi_verify_table > + * > + * PARAMETERS: File - The initrd file > + * Path - Path to acpi overriding tables in cpio file > + * Signature - Signature of the table > + * > + * RETURN: 0 if it passes all the checks, -EINVAL if any check fails. > + * > + * DESCRIPTION: Check if an acpi table found in initrd is invalid. > + * @signature can be NULL. If it is NULL, the function will check > + * if the table signature matches any signature in table_sigs[]. > + * > + ******************************************************************************/ > +int __init acpi_verify_table(struct cpio_data *file, :
| |