Messages in this thread | | | Date | Tue, 06 Aug 2013 05:53:08 -0700 | From | Randy Dunlap <> | Subject | Re: [PATCH] OPP: Export opp_add() |
| |
On 08/03/2013 02:25 AM, Viresh Kumar wrote: > Export opp_add() so that modules can use it. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/base/power/opp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c > index c8ec186..ef89897 100644 > --- a/drivers/base/power/opp.c > +++ b/drivers/base/power/opp.c > @@ -460,6 +460,7 @@ int opp_add(struct device *dev, unsigned long freq, unsigned long u_volt) > srcu_notifier_call_chain(&dev_opp->head, OPP_EVENT_ADD, new_opp); > return 0; > } > +EXPORT_SYMBOL_GPL(opp_add);
Could it be renamed to pm_opp_add() or power_opp_add() ? The name is a bit too unspecific IMO.
> > /** > * opp_set_availability() - helper to set the availability of an opp >
-- ~Randy
| |