lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCHSET 00/17] perf tools: Introduce new 'ftrace' command (v4)
    Date
    Hi Ingo and Jiri,

    On Fri, 2 Aug 2013 11:16:59 +0200, Ingo Molnar wrote:
    > * Jiri Olsa <jolsa@redhat.com> wrote:
    >
    >> On Tue, Jul 30, 2013 at 06:18:57PM +0900, Namhyung Kim wrote:
    >> > This patchset implements a front-end tool for kernel's ftrace. It
    >> > uses function_graph tracer by default and normal function tracer is
    >> > also supported. (Of course you need to enable those tracers in your
    >> > kernel first.)
    >> >
    >> > v4 changes:
    >> > * use pid instead of tid for -p option (David)
    >> > * not to poll() for reading ftrace pipes (Jiri)
    >> > * rename to create_perf_header() (Jiri)
    >> > * canonicalize directory name (Jiri)
    >> > * show more info when -D option was given (Jiri)
    >> > * update documentation (Jiri)
    >> > * and few more bug fixes
    >> >
    >> > I pushed it out to 'perf/ftrace-v4' branch on my tree at:
    >> >
    >> > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
    >> >
    >> >
    >> > Any comments are welcome, thanks,
    >> > Namhyung
    >>
    >> hi,
    >> I've got following error when compiling on Fedora 16:
    >>
    >> CC builtin-ftrace.o
    >> builtin-ftrace.c: In function ???set_tracing_clock???:
    >> builtin-ftrace.c:197:14: error: declaration of ???clock??? shadows a global declaration [-Werror=shadow]
    >> builtin-ftrace.c: In function ???canonicalize_directory_name???:
    >> builtin-ftrace.c:350:53: error: declaration of ???dirname??? shadows a global declaration [-Werror=shadow]
    >> cc1: all warnings being treated as errors
    >>
    >> Fedora 17 seems to be ok.. strange ;-)
    >
    > Might be due to:
    >
    > /usr/include/time.h:extern clock_t clock (void) __THROW;
    >
    > which is a sad namespace land-grab by time.h, 'clock' is such a nice local
    > variable name.

    Thanks for the info. I'll change the names.

    Thanks,
    Namhyung


    \
     
     \ /
      Last update: 2013-08-05 10:01    [W:3.355 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site