Messages in this thread | | | Date | Mon, 5 Aug 2013 16:36:47 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH 17/18] mm, hugetlb: retry if we fail to allocate a hugepage with use_reserve |
| |
> Any mapping that doesn't use the reserved pool, not just > MAP_NORESERVE. For example, if a process makes a MAP_PRIVATE mapping, > then fork()s then the mapping is instantiated in the child, that will > not draw from the reserved pool. > > > Should we ensure them to allocate the last hugepage? > > They map a region with MAP_NORESERVE, so don't assume that their requests > > always succeed. > > If the pages are available, people get cranky if it fails for no > apparent reason, MAP_NORESERVE or not. They get especially cranky if > it sometimes fails and sometimes doesn't due to a race condition.
Hello,
Hmm... Okay. I will try to implement another way to protect race condition. Maybe it is the best to use a table mutex :) Anyway, please give me a time, guys.
Really thank you for pointing that.
| |