Messages in this thread | | | Subject | Re: [PATCH] trivial: adjust code alignment | From | Joe Perches <> | Date | Mon, 05 Aug 2013 17:51:09 -0700 |
| |
On Mon, 2013-08-05 at 19:30 +0300, Dan Carpenter wrote: > On Mon, Aug 05, 2013 at 09:17:07AM -0700, Joe Perches wrote: > > ov7670_read via i2c_transfer can return a positive # too. > > Perhaps all of these should be individually tested for "< 0". > You're misreading something. ov7670_read_i2c() only returns zero > and negative error codes.
Yup, right, thanks, I skimmed over the
if (ret >= 0) { ... ret = 0; }
bit in ov7670_read_i2c
though I think this function via the i2c_transfer can return 0 messages transferred as "success".
| |