lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in machine_kexec_32
On Mon, Aug 05, 2013 at 04:03:27PM -0700, H. Peter Anvin wrote:
> On 08/05/2013 03:02 PM, Andi Kleen wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > A function pointer cannot be asmlinkage. Just drop it.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Eh? It certainly matters for the function pointer if it is regparm(0)
> or regparm(3), and the pointed-to function definitely assumes
> regparm(0). So I think this patch is wrong, and if it isn't, it
> definitely needs better explanation why it isn't wrong.

Ok. Good point.

It causes compiler warnings with __attribute__((externally_visible))
because only a definition can be visible.

But yes it is needed for regparm.

So in a sense these two are incompatible. I guess it can be dropped
right now, as it's just a warning.

So please drop the patch and I'll too.
I'll not repost just for the drop, unless you ask me to
(or other changes come up)

Longer term may need some different solution for this.

-Andi


--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2013-08-06 01:21    [W:0.233 / U:4.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site