lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/16] x86, asmlinkage, kexec: Drop bogus asmlinkage in machine_kexec_32
On 08/05/2013 03:02 PM, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> A function pointer cannot be asmlinkage. Just drop it.
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

Eh? It certainly matters for the function pointer if it is regparm(0)
or regparm(3), and the pointed-to function definitely assumes
regparm(0). So I think this patch is wrong, and if it isn't, it
definitely needs better explanation why it isn't wrong.

-hpa




\
 
 \ /
  Last update: 2013-08-06 01:21    [W:0.112 / U:3.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site