Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable | Date | Mon, 05 Aug 2013 12:10:34 -0700 |
| |
Namhyung Kim <namhyung@kernel.org> writes: > > I wrote a patch series [1] separating gtk code to a dso and use it with > libdl last year. But I didn't get much feedback probably due to the > mistake of not installing the dso to a proper place. It'd be great if > you guys take a look at it and give some comments.
It looks good as a replacement of this patch
Except for the requirement to build libperf as -fPIC In some setups the PIC penalty can be high, and libperf has some very hot code (e.g. callstack merging)
-Andi -- ak@linux.intel.com -- Speaking for myself only
| |