lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] RFC: perf, tools: Move gtk browser into separate perfgtk executable
Date
Namhyung Kim <namhyung@kernel.org> writes:
>
> I wrote a patch series [1] separating gtk code to a dso and use it with
> libdl last year. But I didn't get much feedback probably due to the
> mistake of not installing the dso to a proper place. It'd be great if
> you guys take a look at it and give some comments.

It looks good as a replacement of this patch

Except for the requirement to build libperf as -fPIC
In some setups the PIC penalty can be high, and libperf
has some very hot code (e.g. callstack merging)

-Andi
--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2013-08-05 22:21    [W:0.084 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site