Messages in this thread | | | Date | Mon, 5 Aug 2013 09:52:24 -0700 | From | David Daney <> | Subject | Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S |
| |
On 08/05/2013 06:43 AM, Gleb Natapov wrote: > On Mon, Aug 05, 2013 at 03:21:57PM +0200, Ralf Baechle wrote: >> On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote: >> >>> >>> On 01/08/13 21:22, David Daney wrote: >>>> From: David Daney <david.daney@cavium.com> >>>> >>>> No code changes, just reflowing some comments and consistently using >>>> tabs and spaces. Object code is verified to be unchanged. >>>> >>>> Signed-off-by: David Daney <david.daney@cavium.com> >>>> Acked-by: Ralf Baechle <ralf@linux-mips.org> >>> >>> >>>> + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ >>> >>> git am detects a whitespace error here ("space before tab in indent"). >>> It's got spaces before and after the tab actually. >>> >>>> /* load the guest context from VCPU and return */ >>> >>> this comment could have it's indentation fixed too >>> >>> Otherwise, for all 3 patches: >>> >>> Reviewed-by: James Hogan <james.hogan@imgtec.com> >> >> I'm happy with the patch series as well and will fix this issue when >> applying the patch. >> > kvm fixes usually go through kvm.git tree for all arches. Any special > reasons you want to get those through mips tree? >
I don't really care which tree takes this particular patch set.
However, in the near future, I will be sending revised versions of patches needed by MIPS/KVM that are in files outside of the arch/mips/kvm directory and it is possible that those may suffer patch ordering problems if merged through a 'foreign tree'.
In any event, there is the problem with the whitespace error in the comment. I blame checkpatch.pl for not flagging it, but that is not really a good excuse. If it goes by the KVM tree, do you want me to send a corrected patch? Or can you fix it when you merge it.
David Daney
| |